third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Fixed the Windows Failure Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSParserToken.h ('K') | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

index 01574b5f2b11ff0b285f5480da2434a7617a61ad..de3810017f55b2847e8efa4975ed91617d42617c 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

@@ -96,7 +96,7 @@ bool consumeSlashIncludingWhitespace(CSSParserTokenRange& range) {

}

CSSParserTokenRange consumeFunction(CSSParserTokenRange& range) {

- ASSERT(range.peek().type() == FunctionToken);

+ DCHECK_EQ(range.peek().type(), FunctionToken);

CSSParserTokenRange contents = range.consumeBlock();

range.consumeWhitespace();

contents.consumeWhitespace();

@@ -428,7 +428,7 @@ StringView consumeUrlAsStringView(CSSParserTokenRange& range) {

const CSSParserToken& next = urlArgs.consumeIncludingWhitespace();

if (next.type() == BadStringToken || !urlArgs.atEnd())

return StringView();

- ASSERT(next.type() == StringToken);

+ DCHECK_EQ(next.type(), StringToken);

range = urlRange;

range.consumeWhitespace();

return next.value();

@@ -457,7 +457,7 @@ static int clampRGBComponent(const CSSPrimitiveValue& value) {

static bool parseRGBParameters(CSSParserTokenRange& range,

RGBA32& result,

bool parseAlpha) {

- ASSERT(range.peek().functionId() == CSSValueRgb ||

+ DCHECK(range.peek().functionId() == CSSValueRgb ||

range.peek().functionId() == CSSValueRgba);

CSSParserTokenRange args = consumeFunction(range);

CSSPrimitiveValue* colorParameter = consumeInteger(args);

@@ -497,7 +497,7 @@ static bool parseRGBParameters(CSSParserTokenRange& range,

static bool parseHSLParameters(CSSParserTokenRange& range,

RGBA32& result,

bool parseAlpha) {

- ASSERT(range.peek().functionId() == CSSValueHsl ||

+ DCHECK(range.peek().functionId() == CSSValueHsl ||

range.peek().functionId() == CSSValueHsla);

CSSParserTokenRange args = consumeFunction(range);

CSSPrimitiveValue* hslValue = consumeNumber(args, ValueRangeAll);