third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Fixed the Windows Failure Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSSelector.h ('K') | « third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSAtRuleID.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSParserToken.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

index e827a813e02c8007f3c908cc22257ceac3591ce0..ea4273b00b18559b74d4b980c91198e6cfd66d0a 100644

--- a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

+++ b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

@@ -287,7 +287,7 @@ void StyleInvalidator::pushInvalidationSetsForContainerNode(

DCHECK(pendingInvalidations);

for (const auto& invalidationSet : pendingInvalidations->siblings()) {

- RELEASE_ASSERT(invalidationSet->isAlive());

+ CHECK(invalidationSet->isAlive());

siblingData.pushInvalidationSet(toSiblingInvalidationSet(*invalidationSet));

}

@@ -296,7 +296,7 @@ void StyleInvalidator::pushInvalidationSetsForContainerNode(

if (!pendingInvalidations->descendants().isEmpty()) {

for (const auto& invalidationSet : pendingInvalidations->descendants()) {

- RELEASE_ASSERT(invalidationSet->isAlive());

+ CHECK(invalidationSet->isAlive());

recursionData.pushInvalidationSet(*invalidationSet);

}

if (UNLIKELY(*s_tracingEnabled)) {