third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Fixed the Windows Failure Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp b/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

index 002106cbf9aa9046fbecbf535c658d95074ef058..88ea2ceb275a925d4e4aba91d9f3ddab76567fc5 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

+++ b/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

@@ -38,7 +38,7 @@ MediaQueryMatcher* MediaQueryMatcher::create(Document& document) {

MediaQueryMatcher::MediaQueryMatcher(Document& document)

: m_document(&document) {

- ASSERT(m_document);

+ DCHECK(m_document);

}

MediaQueryMatcher::~MediaQueryMatcher() {}

@@ -56,7 +56,7 @@ MediaQueryEvaluator* MediaQueryMatcher::createEvaluator() const {

}

bool MediaQueryMatcher::evaluate(const MediaQuerySet* media) {

- ASSERT(!m_document || m_document->frame() || !m_evaluator);

+ DCHECK(!m_document || m_document->frame() || !m_evaluator);

if (!media)

return false;