third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Fixed the Windows Failure Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

index a92f5b239cd43aade1010665409c0fc04e115081..55ff4f3015d2c931eb342143a1fea0c0ab5103d5 100644

--- a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

@@ -127,7 +127,7 @@ PassRefPtr<FontData> CSSSegmentedFontFace::getFontData(

continue;

if (RefPtr<SimpleFontData> faceFontData =

(*it)->cssFontFace()->getFontData(requestedFontDescription)) {

- ASSERT(!faceFontData->isSegmented());

+ DCHECK(!faceFontData->isSegmented());

if (faceFontData->isCustomFont()) {

fontData->appendFace(adoptRef(new FontDataForRangeSet(

std::move(faceFontData), (*it)->cssFontFace()->ranges())));