third_party/WebKit/Source/core/css/CSSFontSelector.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Fixed the Windows Failure Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

index 76f6243b336f541551b06273edb1dc0fca20b326..1e2a87e3e9bdca2da790176a2884e4cc6dfa8d63 100644

--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

@@ -49,7 +49,7 @@ CSSFontSelector::CSSFontSelector(Document* document)

// FIXME: An old comment used to say there was no need to hold a reference to

// m_document because "we are guaranteed to be destroyed before the document".

// But there does not seem to be any such guarantee.

- ASSERT(m_document);

+ DCHECK(m_document);

DCHECK(m_document->frame());

FontCache::fontCache()->addClient(this);

FontFaceSet::from(*document)->addFontFacesToFontFaceCache(&m_fontFaceCache,