third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

index ad887b340c610805921112b092eee62ed433f95b..00af0d89717061a705e571302bc7de1b8361adc5 100644

--- a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

@@ -328,13 +328,13 @@ TransformOperations TransformBuilder::createTransformOperations(

}

case TransformOperation::Perspective: {

double p = firstValue.computeLength<double>(conversionData);

- ASSERT(p >= 0);

+ DCHECK_GE(p, 0);

operations.operations().push_back(

PerspectiveTransformOperation::create(p));

break;

}

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

break;

}