Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Source/core/css/RuleSet.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RuleSet.cpp
diff --git a/third_party/WebKit/Source/core/css/RuleSet.cpp b/third_party/WebKit/Source/core/css/RuleSet.cpp
index e2505aec302b160d8de5397d75f1c9ac21be7a39..c39b5fa9a0752832a3a2e6f2652087bbf2efe4ca 100644
--- a/third_party/WebKit/Source/core/css/RuleSet.cpp
+++ b/third_party/WebKit/Source/core/css/RuleSet.cpp
@@ -203,7 +203,8 @@ bool RuleSet::findBestRuleSetAndAdd(const CSSSelector& component,
// and have a relation of ShadowPseudo between them. Therefore we should
// never be a situation where extractValuesforSelector finsd id and
// className in addition to custom pseudo.
- ASSERT(id.isEmpty() && className.isEmpty());
+ DCHECK(id.isEmpty());
+ DCHECK(className.isEmpty());
addToRuleSet(customPseudoElementName,
ensurePendingRules()->shadowPseudoElementRules, ruleData);
return true;
@@ -323,7 +324,7 @@ void RuleSet::addRulesFromSheet(StyleSheetContents* sheet,
AddRuleFlags addRuleFlags) {
TRACE_EVENT0("blink", "RuleSet::addRulesFromSheet");
- ASSERT(sheet);
+ DCHECK(sheet);
const HeapVector<Member<StyleRuleImport>>& importRules = sheet->importRules();
for (unsigned i = 0; i < importRules.size(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698