Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
index 84e9da0fa88d97025d84616e20c7105e9b235a5a..bc51829d9f53167e8308b1ae8b91b2ef080d852d 100644
--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
@@ -171,7 +171,7 @@ void RemoteFontFaceSource::fontLoadLongLimitExceeded(FontResource*) {
}
void RemoteFontFaceSource::switchToSwapPeriod() {
- ASSERT(m_period == BlockPeriod);
+ DCHECK_EQ(m_period, BlockPeriod);
m_period = SwapPeriod;
pruneTable();
@@ -186,7 +186,7 @@ void RemoteFontFaceSource::switchToSwapPeriod() {
void RemoteFontFaceSource::switchToFailurePeriod() {
if (m_period == BlockPeriod)
switchToSwapPeriod();
- ASSERT(m_period == SwapPeriod);
+ DCHECK_EQ(m_period, SwapPeriod);
m_period = FailurePeriod;
}
@@ -240,7 +240,7 @@ PassRefPtr<SimpleFontData> RemoteFontFaceSource::createLoadingFallbackFontData(
FontCache::fontCache()->getNonRetainedLastResortFallbackFont(
fontDescription);
if (!temporaryFont) {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
RefPtr<CSSCustomFontData> cssFontData = CSSCustomFontData::create(

Powered by Google App Engine
This is Rietveld 408576698