Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: third_party/WebKit/Source/core/css/FontSize.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/FontSize.cpp
diff --git a/third_party/WebKit/Source/core/css/FontSize.cpp b/third_party/WebKit/Source/core/css/FontSize.cpp
index a91ca825f254b2fd9954ab7288f9f4f003b40809..5ba98f2446ded4adb1fda9dca1b030e8ce9c4dab 100644
--- a/third_party/WebKit/Source/core/css/FontSize.cpp
+++ b/third_party/WebKit/Source/core/css/FontSize.cpp
@@ -141,7 +141,8 @@ static int inline rowFromMediumFontSizeInRange(const Settings* settings,
float FontSize::fontSizeForKeyword(const Document* document,
unsigned keyword,
bool isMonospace) {
- ASSERT(keyword >= 1 && keyword <= 8);
+ DCHECK_GE(keyword, static_cast<unsigned>(1));
tkent 2017/03/28 14:44:55 static_cast<unsigned>(1) -> 1u
nikhil.sahni 2017/03/30 12:17:57 Done.
+ DCHECK_LE(keyword, static_cast<unsigned>(8));
tkent 2017/03/28 14:44:55 static_cast<unsigned>(8) -> 8u
nikhil.sahni 2017/03/30 12:17:57 Done.
const Settings* settings = document->settings();
if (!settings)
return 1.0f;

Powered by Google App Engine
This is Rietveld 408576698