third_party/WebKit/Source/core/css/CSSPrimitiveValue.h - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

index cc86ca2cd67c980209ed8adc6fb4f9c3343eb8e5..b90cf4fbb5f30128327233ae7aba9a23d50e717a 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

@@ -245,7 +245,7 @@ class CORE_EXPORT CSSPrimitiveValue : public CSSValue {

}

CSSCalcValue* cssCalcValue() const {

- ASSERT(isCalculated());

+ DCHECK(isCalculated());

return m_value.calc;

}