third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp b/third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp

index a1271fc6cf32695c915d966c02d026028aca605c..06bb9e9d5ce57989d5e3f0ae57f805e559fc04d3 100644

--- a/third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp

@@ -30,7 +30,7 @@ TEST(CSSPageRule, selectorText) {

const char* cssRule = "@page :left { size: auto; }";

helper.addCSSRules(cssRule);

- ASSERT(helper.cssRules());

+ DCHECK(helper.cssRules());

EXPECT_EQ(1u, helper.cssRules()->length());

CSSPageRule* pageRule = toCSSPageRule(helper.cssRules()->item(0));