Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp b/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
index f80fd37122b70ae8a87f947f367f92cfbab00d6a..0eb3bd86c5dece8437c92ea0ea925ab0db163230 100644
--- a/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
+++ b/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
@@ -95,8 +95,8 @@ void CSSKeyframesRule::setName(const String& name) {
}
void CSSKeyframesRule::appendRule(const String& ruleText) {
- ASSERT(m_childRuleCSSOMWrappers.size() ==
- m_keyframesRule->keyframes().size());
+ DCHECK_EQ(m_childRuleCSSOMWrappers.size(),
+ m_keyframesRule->keyframes().size());
CSSStyleSheet* styleSheet = parentStyleSheet();
CSSParserContext* context =
@@ -113,8 +113,8 @@ void CSSKeyframesRule::appendRule(const String& ruleText) {
}
void CSSKeyframesRule::deleteRule(const String& s) {
- ASSERT(m_childRuleCSSOMWrappers.size() ==
- m_keyframesRule->keyframes().size());
+ DCHECK_EQ(m_childRuleCSSOMWrappers.size(),
+ m_keyframesRule->keyframes().size());
int i = m_keyframesRule->findKeyframeIndex(s);
if (i < 0)
@@ -161,8 +161,8 @@ CSSKeyframeRule* CSSKeyframesRule::item(unsigned index) const {
if (index >= length())
return nullptr;
- ASSERT(m_childRuleCSSOMWrappers.size() ==
- m_keyframesRule->keyframes().size());
+ DCHECK_EQ(m_childRuleCSSOMWrappers.size(),
+ m_keyframesRule->keyframes().size());
Member<CSSKeyframeRule>& rule = m_childRuleCSSOMWrappers[index];
if (!rule)
rule = new CSSKeyframeRule(m_keyframesRule->keyframes()[index].get(),
@@ -190,7 +190,7 @@ CSSRuleList* CSSKeyframesRule::cssRules() const {
}
void CSSKeyframesRule::reattach(StyleRuleBase* rule) {
- ASSERT(rule);
+ DCHECK(rule);
m_keyframesRule = toStyleRuleKeyframes(rule);
}

Powered by Google App Engine
This is Rietveld 408576698