third_party/WebKit/Source/core/css/CSSImageValue.h - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.h

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSImageValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.h b/third_party/WebKit/Source/core/css/CSSImageValue.h

index 6105584ebd2f321c13afe95c4e9e9d0e9ed67aa6..9ac9b7b242c8131a26958d79872f7164a3415b63 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.h

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.h

@@ -56,7 +56,7 @@ class CORE_EXPORT CSSImageValue : public CSSValue {

bool isCachePending() const { return !m_cachedImage; }

StyleImage* cachedImage() const {

- ASSERT(!isCachePending());

+ DCHECK(!isCachePending());

return m_cachedImage.get();

}

StyleImage* cacheImage(