Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp b/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
index 641b831d924b8c2054707471773d8deeaa4ec552..c6a4de9c56c1e991b01e67f0bd400535462c1942 100644
--- a/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
@@ -40,9 +40,9 @@ CSSImageGeneratorValue::~CSSImageGeneratorValue() {}
void CSSImageGeneratorValue::addClient(const LayoutObject* layoutObject,
const IntSize& size) {
- ASSERT(layoutObject);
+ DCHECK(layoutObject);
if (m_clients.isEmpty()) {
- ASSERT(!m_keepAlive);
+ DCHECK(!m_keepAlive);
m_keepAlive = this;
}
@@ -65,7 +65,7 @@ CSSImageGeneratorValue* CSSImageGeneratorValue::valueWithURLsMadeAbsolute() {
}
void CSSImageGeneratorValue::removeClient(const LayoutObject* layoutObject) {
- ASSERT(layoutObject);
+ DCHECK(layoutObject);
LayoutObjectSizeCountMap::iterator it = m_clients.find(layoutObject);
SECURITY_DCHECK(it != m_clients.end());
@@ -82,7 +82,7 @@ void CSSImageGeneratorValue::removeClient(const LayoutObject* layoutObject) {
m_clients.erase(layoutObject);
if (m_clients.isEmpty()) {
- ASSERT(m_keepAlive);
+ DCHECK(m_keepAlive);
m_keepAlive.clear();
}
}
@@ -126,7 +126,7 @@ PassRefPtr<Image> CSSImageGeneratorValue::image(
case RadialGradientClass:
return toCSSRadialGradientValue(this)->image(layoutObject, size);
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return nullptr;
}
@@ -142,7 +142,7 @@ bool CSSImageGeneratorValue::isFixedSize() const {
case RadialGradientClass:
return toCSSRadialGradientValue(this)->isFixedSize();
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return false;
}
@@ -160,7 +160,7 @@ IntSize CSSImageGeneratorValue::fixedSize(const LayoutObject& layoutObject,
case RadialGradientClass:
return toCSSRadialGradientValue(this)->fixedSize(layoutObject);
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return IntSize();
}
@@ -176,7 +176,7 @@ bool CSSImageGeneratorValue::isPending() const {
case RadialGradientClass:
return toCSSRadialGradientValue(this)->isPending();
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return false;
}
@@ -193,7 +193,7 @@ bool CSSImageGeneratorValue::knownToBeOpaque(
case RadialGradientClass:
return toCSSRadialGradientValue(this)->knownToBeOpaque(layoutObject);
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return false;
}
@@ -213,7 +213,7 @@ void CSSImageGeneratorValue::loadSubimages(const Document& document) {
toCSSRadialGradientValue(this)->loadSubimages(document);
break;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
}

Powered by Google App Engine
This is Rietveld 408576698