third_party/WebKit/Source/core/css/CSSCalculationValue.h - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCalculationValue.h

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCalculationValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSCalculationValue.h b/third_party/WebKit/Source/core/css/CSSCalculationValue.h

index 46ce3d7bfc8f2a59bb2220aa936ee2bd03128119..5c2e429e04262232f6731117816aadd49881c8a8 100644

--- a/third_party/WebKit/Source/core/css/CSSCalculationValue.h

+++ b/third_party/WebKit/Source/core/css/CSSCalculationValue.h

@@ -95,7 +95,7 @@ class CSSCalcExpressionNode : public GarbageCollected<CSSCalcExpressionNode> {

protected:

CSSCalcExpressionNode(CalculationCategory category, bool isInteger)

: m_category(category), m_isInteger(isInteger) {

- ASSERT(category != CalcOther);

+ DCHECK_NE(category, CalcOther);

}

CalculationCategory m_category;