Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2840)

Unified Diff: third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
diff --git a/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp b/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
index ae17742f73b0acadc9e863c917dccd869803be8c..c25bca8b9fe1e1cc0bd5cdbc951d65b59b6beb80 100644
--- a/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
+++ b/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
@@ -74,7 +74,7 @@ static CSSValue* basicShapeRadiusToCSSValue(const ComputedStyle& style,
return CSSIdentifierValue::create(CSSValueFarthestSide);
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
@@ -202,7 +202,7 @@ static BasicShapeCenterCoordinate convertToCenterCoordinate(
offset = Length(50, Percent);
break;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
direction = BasicShapeCenterCoordinate::TopLeft;
break;
}
@@ -223,7 +223,7 @@ static BasicShapeRadius cssValueToBasicShapeRadius(
case CSSValueFarthestSide:
return BasicShapeRadius(BasicShapeRadius::FarthestSide);
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
break;
}
}
@@ -293,7 +293,7 @@ PassRefPtr<BasicShape> basicShapeForValue(const StyleResolverState& state,
basicShape = std::move(rect);
} else {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return basicShape.release();

Powered by Google App Engine
This is Rietveld 408576698