Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp
diff --git a/third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp b/third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp
index cd50b3cc554fc9191e1a649743b383b79ae97a33..0cad9050461968a0567d73d30a0049774bfb8bb4 100644
--- a/third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp
+++ b/third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp
@@ -43,7 +43,7 @@ class AffectedByFocusTest : public ::testing::Test {
void AffectedByFocusTest::SetUp() {
m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600));
m_document = &m_dummyPageHolder->document();
- ASSERT(m_document);
+ DCHECK(m_document);
}
void AffectedByFocusTest::setHtmlInnerHTML(const char* htmlContent) {
@@ -59,14 +59,15 @@ void AffectedByFocusTest::checkElements(ElementResult expected[],
for (; element && i < expectedCount;
element = Traversal<HTMLElement>::next(*element), ++i) {
ASSERT_TRUE(element->hasTagName(expected[i].tag));
- ASSERT(element->computedStyle());
+ DCHECK(element->computedStyle());
ASSERT_EQ(expected[i].affectedBy,
element->computedStyle()->affectedByFocus());
ASSERT_EQ(expected[i].childrenOrSiblingsAffectedBy,
element->childrenOrSiblingsAffectedByFocus());
}
- ASSERT(!element && i == expectedCount);
+ DCHECK(!element);
+ DCHECK_EQ(i, expectedCount);
}
// A global :focus rule in html.css currently causes every single element to be

Powered by Google App Engine
This is Rietveld 408576698