third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp b/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

index c8d2c22c63cdca9337ba1a8d9cc8b32d19022fdb..47b95319413f88613f20389bdcd5dad33472e384 100644

--- a/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

@@ -16,7 +16,7 @@ SizesCalcParser::SizesCalcParser(CSSParserTokenRange range,

}

float SizesCalcParser::result() const {

- ASSERT(m_isValid);

+ DCHECK(m_isValid);

return m_result;

}

@@ -130,7 +130,7 @@ bool SizesCalcParser::calcToReversePolishNotation(CSSParserTokenRange range) {

case EOFToken:

break;

case CommentToken:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

case CDOToken:

case CDCToken:

case AtKeywordToken: