third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('K') | « third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h ('k') | third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

index 1b97406af78d7089b8c16ab244d1b20ff5acb795..e2b8b3020d26a6e0aab49e57f1673a8ba0b34b51 100644

--- a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

@@ -62,11 +62,11 @@ class StyleAttributeMutationScope {

++s_scopeCount;

if (s_scopeCount != 1) {

- ASSERT(s_currentDecl == decl);

+ DCHECK_EQ(s_currentDecl, decl);

return;

}

- ASSERT(!s_currentDecl);

+ DCHECK(!s_currentDecl);

s_currentDecl = decl;

if (!s_currentDecl->parentElement())