third_party/WebKit/Source/core/css/FontSize.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontSize.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/FontSize.cpp

diff --git a/third_party/WebKit/Source/core/css/FontSize.cpp b/third_party/WebKit/Source/core/css/FontSize.cpp

index a91ca825f254b2fd9954ab7288f9f4f003b40809..5ba98f2446ded4adb1fda9dca1b030e8ce9c4dab 100644

--- a/third_party/WebKit/Source/core/css/FontSize.cpp

+++ b/third_party/WebKit/Source/core/css/FontSize.cpp

@@ -141,7 +141,8 @@ static int inline rowFromMediumFontSizeInRange(const Settings* settings,

float FontSize::fontSizeForKeyword(const Document* document,

unsigned keyword,

bool isMonospace) {

- ASSERT(keyword >= 1 && keyword <= 8);

+ DCHECK_GE(keyword, static_cast<unsigned>(1));

+ DCHECK_LE(keyword, static_cast<unsigned>(8));

const Settings* settings = document->settings();

if (!settings)

return 1.0f;