Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/core/css/FontFace.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/FontFace.cpp
diff --git a/third_party/WebKit/Source/core/css/FontFace.cpp b/third_party/WebKit/Source/core/css/FontFace.cpp
index b9b5f639df01d5b00c71285533e33b6ba070bfc8..94fd7e39fb994a774049a778abfcc39a86b4245e 100644
--- a/third_party/WebKit/Source/core/css/FontFace.cpp
+++ b/third_party/WebKit/Source/core/css/FontFace.cpp
@@ -366,7 +366,7 @@ String FontFace::status() const {
void FontFace::setLoadStatus(LoadStatusType status) {
m_status = status;
- ASSERT(m_status != Error || m_error);
+ DCHECK(m_status != Error || m_error);
// When promises are resolved with 'thenables', instead of the object being
// returned directly, the 'then' method is executed (the resolver tries to
@@ -543,7 +543,7 @@ FontTraits FontFace::traits() const {
case CSSValueBolder:
break;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
break;
}
}
@@ -599,8 +599,8 @@ void FontFace::initCSSFontFace(Document* document, const CSSValue* src) {
// Each item in the src property's list is a single CSSFontFaceSource. Put
// them all into a CSSFontFace.
- ASSERT(src);
- ASSERT(src->isValueList());
+ DCHECK(src);
+ DCHECK(src->isValueList());
const CSSValueList* srcList = toCSSValueList(src);
int srcLength = srcList->length();

Powered by Google App Engine
This is Rietveld 408576698