third_party/WebKit/Source/core/css/CSSToLengthConversionData.h - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSToLengthConversionData.h

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSToLengthConversionData.h

diff --git a/third_party/WebKit/Source/core/css/CSSToLengthConversionData.h b/third_party/WebKit/Source/core/css/CSSToLengthConversionData.h

index efdb1c7b9aea3672ec170c973b352c8104f3dcd5..f23bf053a83059bbee2160c1d747ba34c4f5acc4 100644

--- a/third_party/WebKit/Source/core/css/CSSToLengthConversionData.h

+++ b/third_party/WebKit/Source/core/css/CSSToLengthConversionData.h

@@ -108,7 +108,8 @@ class CORE_EXPORT CSSToLengthConversionData {

void setFontSizes(const FontSizes& fontSizes) { m_fontSizes = fontSizes; }

void setZoom(float zoom) {

- ASSERT(std::isfinite(zoom) && zoom > 0);

+ DCHECK(std::isfinite(zoom));

+ DCHECK_GT(zoom, 0);

m_zoom = zoom;

}