Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSStyleRule.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: All windows error are Resolved now. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org) 3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 selector; selector = CSSSelectorList::next(*selector)) { 58 selector; selector = CSSSelectorList::next(*selector)) {
59 if (selector != m_styleRule->selectorList().first()) 59 if (selector != m_styleRule->selectorList().first())
60 builder.append(", "); 60 builder.append(", ");
61 builder.append(selector->selectorText()); 61 builder.append(selector->selectorText());
62 } 62 }
63 return builder.toString(); 63 return builder.toString();
64 } 64 }
65 65
66 String CSSStyleRule::selectorText() const { 66 String CSSStyleRule::selectorText() const {
67 if (hasCachedSelectorText()) { 67 if (hasCachedSelectorText()) {
68 ASSERT(selectorTextCache().contains(this)); 68 DCHECK(selectorTextCache().contains(this));
69 return selectorTextCache().at(this); 69 return selectorTextCache().at(this);
70 } 70 }
71 71
72 ASSERT(!selectorTextCache().contains(this)); 72 DCHECK(!selectorTextCache().contains(this));
73 String text = generateSelectorText(); 73 String text = generateSelectorText();
74 selectorTextCache().set(this, text); 74 selectorTextCache().set(this, text);
75 setHasCachedSelectorText(true); 75 setHasCachedSelectorText(true);
76 return text; 76 return text;
77 } 77 }
78 78
79 void CSSStyleRule::setSelectorText(const String& selectorText) { 79 void CSSStyleRule::setSelectorText(const String& selectorText) {
80 const CSSParserContext* context = 80 const CSSParserContext* context =
81 CSSParserContext::create(parserContext(), nullptr); 81 CSSParserContext::create(parserContext(), nullptr);
82 CSSSelectorList selectorList = CSSParser::parseSelector( 82 CSSSelectorList selectorList = CSSParser::parseSelector(
(...skipping 18 matching lines...) Expand all
101 result.append(" { "); 101 result.append(" { ");
102 String decls = m_styleRule->properties().asText(); 102 String decls = m_styleRule->properties().asText();
103 result.append(decls); 103 result.append(decls);
104 if (!decls.isEmpty()) 104 if (!decls.isEmpty())
105 result.append(' '); 105 result.append(' ');
106 result.append('}'); 106 result.append('}');
107 return result.toString(); 107 return result.toString();
108 } 108 }
109 109
110 void CSSStyleRule::reattach(StyleRuleBase* rule) { 110 void CSSStyleRule::reattach(StyleRuleBase* rule) {
111 ASSERT(rule); 111 DCHECK(rule);
112 m_styleRule = toStyleRule(rule); 112 m_styleRule = toStyleRule(rule);
113 if (m_propertiesCSSOMWrapper) 113 if (m_propertiesCSSOMWrapper)
114 m_propertiesCSSOMWrapper->reattach(m_styleRule->mutableProperties()); 114 m_propertiesCSSOMWrapper->reattach(m_styleRule->mutableProperties());
115 } 115 }
116 116
117 DEFINE_TRACE(CSSStyleRule) { 117 DEFINE_TRACE(CSSStyleRule) {
118 visitor->trace(m_styleRule); 118 visitor->trace(m_styleRule);
119 visitor->trace(m_propertiesCSSOMWrapper); 119 visitor->trace(m_propertiesCSSOMWrapper);
120 CSSRule::trace(visitor); 120 CSSRule::trace(visitor);
121 } 121 }
122 122
123 DEFINE_TRACE_WRAPPERS(CSSStyleRule) { 123 DEFINE_TRACE_WRAPPERS(CSSStyleRule) {
124 visitor->traceWrappers(parentRule()); 124 visitor->traceWrappers(parentRule());
125 visitor->traceWrappers(parentStyleSheet()); 125 visitor->traceWrappers(parentStyleSheet());
126 CSSRule::traceWrappers(visitor); 126 CSSRule::traceWrappers(visitor);
127 } 127 }
128 128
129 } // namespace blink 129 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSSelectorList.cpp ('k') | third_party/WebKit/Source/core/css/CSSToLengthConversionData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698