Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 toCSSPrimitiveValue(transformValue->item(13)).getDoubleValue(), 321 toCSSPrimitiveValue(transformValue->item(13)).getDoubleValue(),
322 toCSSPrimitiveValue(transformValue->item(14)).getDoubleValue(), 322 toCSSPrimitiveValue(transformValue->item(14)).getDoubleValue(),
323 toCSSPrimitiveValue(transformValue->item(15)).getDoubleValue()); 323 toCSSPrimitiveValue(transformValue->item(15)).getDoubleValue());
324 matrix.zoom(zoomFactor); 324 matrix.zoom(zoomFactor);
325 operations.operations().push_back( 325 operations.operations().push_back(
326 Matrix3DTransformOperation::create(matrix)); 326 Matrix3DTransformOperation::create(matrix));
327 break; 327 break;
328 } 328 }
329 case TransformOperation::Perspective: { 329 case TransformOperation::Perspective: {
330 double p = firstValue.computeLength<double>(conversionData); 330 double p = firstValue.computeLength<double>(conversionData);
331 ASSERT(p >= 0); 331 DCHECK_GE(p, 0);
332 operations.operations().push_back( 332 operations.operations().push_back(
333 PerspectiveTransformOperation::create(p)); 333 PerspectiveTransformOperation::create(p));
334 break; 334 break;
335 } 335 }
336 default: 336 default:
337 ASSERT_NOT_REACHED(); 337 NOTREACHED();
338 break; 338 break;
339 } 339 }
340 } 340 }
341 return operations; 341 return operations;
342 } 342 }
343 343
344 } // namespace blink 344 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698