third_party/WebKit/Source/core/css/CSSPageRule.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/css/CSSGradientValue.cpp ('K') | « third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp ('k') | third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp » ('j') | third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)	2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)

3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)	3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)

4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.	4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 result.append("{ ");	78 result.append("{ ");

79 String decls = m_pageRule->properties().asText();	79 String decls = m_pageRule->properties().asText();

80 result.append(decls);	80 result.append(decls);

81 if (!decls.isEmpty())	81 if (!decls.isEmpty())

82 result.append(' ');	82 result.append(' ');

83 result.append('}');	83 result.append('}');

84 return result.toString();	84 return result.toString();

85 }	85 }

86	86

87 void CSSPageRule::reattach(StyleRuleBase* rule) {	87 void CSSPageRule::reattach(StyleRuleBase* rule) {

88 ASSERT(rule);	88 DCHECK(rule);

89 m_pageRule = toStyleRulePage(rule);	89 m_pageRule = toStyleRulePage(rule);

90 if (m_propertiesCSSOMWrapper)	90 if (m_propertiesCSSOMWrapper)

91 m_propertiesCSSOMWrapper->reattach(m_pageRule->mutableProperties());	91 m_propertiesCSSOMWrapper->reattach(m_pageRule->mutableProperties());

92 }	92 }

93	93

94 DEFINE_TRACE(CSSPageRule) {	94 DEFINE_TRACE(CSSPageRule) {

95 visitor->trace(m_pageRule);	95 visitor->trace(m_pageRule);

96 visitor->trace(m_propertiesCSSOMWrapper);	96 visitor->trace(m_propertiesCSSOMWrapper);

97 CSSRule::trace(visitor);	97 CSSRule::trace(visitor);

98 }	98 }

99	99

100 } // namespace blink	100 } // namespace blink

OLD	NEW