Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: content/browser/renderer_host/delegated_frame_host.cc

Issue 2755463002: [cc] Fix CompositorFrameSinkSupport BeginFrameAck interface. (Closed)
Patch Set: sync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/delegated_frame_host.cc
diff --git a/content/browser/renderer_host/delegated_frame_host.cc b/content/browser/renderer_host/delegated_frame_host.cc
index e67e091be4841542673c8e37c67d91bf3864982d..2f9b767e4bb39b200a1af851c531b66791734b34 100644
--- a/content/browser/renderer_host/delegated_frame_host.cc
+++ b/content/browser/renderer_host/delegated_frame_host.cc
@@ -848,9 +848,9 @@ void DelegatedFrameHost::OnDidFinishFrame(const cc::BeginFrameAck& ack) {
modified_ack.latest_confirmed_sequence_number;
}
- // TODO(eseckler): The interface to CompositorFrameSinkSupport should use
- // SubmitCompositorFrame and BeginFrameDidNotSwap instead of DidFinishFrame.
- support_->DidFinishFrame(modified_ack);
+ // If there was damage, the unmodified ack was sent with the CompositorFrame.
+ if (!modified_ack.has_damage)
+ support_->BeginFrameDidNotSwap(modified_ack);
}
void DelegatedFrameHost::CreateCompositorFrameSinkSupport() {

Powered by Google App Engine
This is Rietveld 408576698