Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 2755463002: [cc] Fix CompositorFrameSinkSupport BeginFrameAck interface. (Closed)
Patch Set: sync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/surfaces_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/hardware_renderer.cc
diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc
index b4cc30fe769a9390e190ba1a674b6aa5acc8618f..655dd44415b2571f754198a59bf6af2e24ddbe66 100644
--- a/android_webview/browser/hardware_renderer.cc
+++ b/android_webview/browser/hardware_renderer.cc
@@ -167,7 +167,11 @@ void HardwareRenderer::DestroySurface() {
DCHECK(child_id_.is_valid());
// Submit an empty frame to force any existing resources to be returned.
- support_->SubmitCompositorFrame(child_id_, cc::CompositorFrame());
+ cc::CompositorFrame frame;
+ // We submit without a prior BeginFrame, so acknowledge a manual BeginFrame.
+ frame.metadata.begin_frame_ack =
+ cc::BeginFrameAck::CreateManualAckWithDamage();
+ support_->SubmitCompositorFrame(child_id_, std::move(frame));
surfaces_->RemoveChildId(cc::SurfaceId(frame_sink_id_, child_id_));
support_->EvictFrame();
child_id_ = cc::LocalSurfaceId();
« no previous file with comments | « no previous file | android_webview/browser/surfaces_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698