components/exo/compositor_frame_sink_holder.cc - Issue 2755463002: [cc] Fix CompositorFrameSinkSupport BeginFrameAck interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/exo/compositor_frame_sink_holder.cc

Issue 2755463002: [cc] Fix CompositorFrameSinkSupport BeginFrameAck interface. (Closed)

Patch Set: pass on acks to MojoCFSs in clients. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/exo/compositor_frame_sink_holder.cc

diff --git a/components/exo/compositor_frame_sink_holder.cc b/components/exo/compositor_frame_sink_holder.cc

index 3d6e5a2716e09fa5bfb30535ffe5bfa3984df74c..c21346fc51b71d6979652fc38cf8e9ba1c5c742b 100644

--- a/components/exo/compositor_frame_sink_holder.cc

+++ b/components/exo/compositor_frame_sink_holder.cc

@@ -75,7 +75,9 @@ void CompositorFrameSinkHolder::OnNeedsBeginFrames(bool needs_begin_frames) {

}

void CompositorFrameSinkHolder::OnDidFinishFrame(const cc::BeginFrameAck& ack) {

- // TODO(eseckler): Pass on the ack to frame_sink_.

+ // If there was damage, the submitted CompositorFrame includes the ack.

+ if (!ack.has_damage)

+ frame_sink_->BeginFrameDidNotSwap(ack);

}

////////////////////////////////////////////////////////////////////////////////