cc/ipc/mojo_compositor_frame_sink.mojom - Issue 2755463002: [cc] Fix CompositorFrameSinkSupport BeginFrameAck interface.

Unified Diff: cc/ipc/mojo_compositor_frame_sink.mojom

Issue 2755463002: [cc] Fix CompositorFrameSinkSupport BeginFrameAck interface. (Closed)

Patch Set: add BeginFrameDidNotSwap to MojoCFS. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/ipc/mojo_compositor_frame_sink.mojom

diff --git a/cc/ipc/mojo_compositor_frame_sink.mojom b/cc/ipc/mojo_compositor_frame_sink.mojom

index 96aff284e98f3a286dd797b8165e697b60795e1e..b2e4baec18d3d47167d539779ed6237245e93644 100644

--- a/cc/ipc/mojo_compositor_frame_sink.mojom

+++ b/cc/ipc/mojo_compositor_frame_sink.mojom

@@ -35,6 +35,10 @@ interface MojoCompositorFrameSink {

SubmitCompositorFrame(cc.mojom.LocalSurfaceId local_surface_id,

cc.mojom.CompositorFrame frame);

+ // Notifies the frame sink that a BeginFrame was completed, but that no

+ // CompositorFrame was produced as a result of it.

+ BeginFrameDidNotSwap(cc.mojom.BeginFrameAck ack);

Fady Samuel 2017/03/17 13:16:07 Just a question, maybe this can be addressed in a

Eric Seckler 2017/03/17 13:40:22 It is called by users of MojoCompositorFrameSink a

Fady Samuel 2017/03/17 13:45:25 Ohh I see, then you should update a couple of TODO

Eric Seckler 2017/03/17 14:01:11 Ok, sure while we're at it - I guess this shouldn'

// Notify that the surface is no longer in use (and is okay to be evicted) so

// that its resources gets returned in time.

EvictFrame();