[cc] Fix CompositorFrameSinkSupport BeginFrameAck interface.

android_webview/browser/hardware_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/hardware_renderer.h"
 
 #include <utility>
 
 #include "android_webview/browser/aw_gl_surface.h"
 #include "android_webview/browser/aw_render_thread_context_provider.h"
@@ skipping 149 matching lines @@
 void HardwareRenderer::AllocateSurface() {
   DCHECK(!child_id_.is_valid());
   child_id_ = local_surface_id_allocator_->GenerateId();
   surfaces_->AddChildId(cc::SurfaceId(frame_sink_id_, child_id_));
 }
 
 void HardwareRenderer::DestroySurface() {
   DCHECK(child_id_.is_valid());
 
   // Submit an empty frame to force any existing resources to be returned.
-  support_->SubmitCompositorFrame(child_id_, cc::CompositorFrame());
+  cc::CompositorFrame frame;
+  // We submit without a prior BeginFrame, so acknowledge a manual BeginFrame.
+  frame.metadata.begin_frame_ack =
+      cc::BeginFrameAck(cc::BeginFrameArgs::kManualSourceId,
+                        cc::BeginFrameArgs::kStartingFrameNumber,
+                        cc::BeginFrameArgs::kStartingFrameNumber, 0, true);

[piman, 2017/03/17 18:12:01]

nit: this is used in many places, maybe a static
cc::BeginFrameAck::MakeManualFrameAck() would be helpful?

[Eric Seckler, 2017/03/20 11:54:03]

Done.

+  support_->SubmitCompositorFrame(child_id_, std::move(frame));
   surfaces_->RemoveChildId(cc::SurfaceId(frame_sink_id_, child_id_));
   support_->EvictFrame();
   child_id_ = cc::LocalSurfaceId();
 }
 
 void HardwareRenderer::DidReceiveCompositorFrameAck() {}
 
 void HardwareRenderer::OnBeginFrame(const cc::BeginFrameArgs& args) {
   // TODO(tansell): Hook this up.
 }
@@ skipping 72 matching lines @@
 
 void HardwareRenderer::CreateNewCompositorFrameSinkSupport() {
   support_.reset();
   support_ = base::MakeUnique<cc::CompositorFrameSinkSupport>(
       this, surfaces_->GetSurfaceManager(), frame_sink_id_, false /* is_root */,
       false /* handles_frame_sink_id_invalidation */,
       true /* needs_sync_points */);
 }
 
 }  // namespace android_webview