align fasta.PrecedenceInfo.precedence with analyzer.TokenType.precedence

pkg/front_end/lib/src/scanner/token.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Defines the tokens that are produced by the scanner, used by the parser, and
  * referenced from the [AST structure](ast.dart).
  */
 import 'dart:collection';
 
@@ skipping 991 matching lines @@
   static const TokenType LT_LT_EQ =
       const TokenType._('LT_LT_EQ', TokenClass.ASSIGNMENT_OPERATOR, '<<=');
 
   static const TokenType MINUS =
       const TokenType._('MINUS', TokenClass.ADDITIVE_OPERATOR, '-');
 
   static const TokenType MINUS_EQ =
       const TokenType._('MINUS_EQ', TokenClass.ASSIGNMENT_OPERATOR, '-=');
 
   static const TokenType MINUS_MINUS =
-      const TokenType._('MINUS_MINUS', TokenClass.UNARY_PREFIX_OPERATOR, '--');
+      const TokenType._('MINUS_MINUS', TokenClass.UNARY_POSTFIX_OPERATOR, '--');

[Brian Wilkerson, 2017/03/15 13:50:33]

I'm not sure what the right answer is here. Note that both '--' and '++' are
both prefix and postfix operators. I don't know whether using the smaller or
larger of the two is the right solution, nor am I convinced that it makes a
difference.

I'm confident that it doesn't matter for analyzer's parser, because it doesn't
use any precedence information for anything. I'd have to do a code search to see
where analyzer / server does use this information.

 
   static const TokenType OPEN_CURLY_BRACKET =
       const TokenType._('OPEN_CURLY_BRACKET', TokenClass.NO_CLASS, '{');
 
   static const TokenType OPEN_PAREN =
       const TokenType._('OPEN_PAREN', TokenClass.UNARY_POSTFIX_OPERATOR, '(');
 
   static const TokenType OPEN_SQUARE_BRACKET = const TokenType._(
       'OPEN_SQUARE_BRACKET', TokenClass.UNARY_POSTFIX_OPERATOR, '[');
 
   static const TokenType PERCENT =
       const TokenType._('PERCENT', TokenClass.MULTIPLICATIVE_OPERATOR, '%');
 
   static const TokenType PERCENT_EQ =
       const TokenType._('PERCENT_EQ', TokenClass.ASSIGNMENT_OPERATOR, '%=');
 
   static const TokenType PERIOD =
       const TokenType._('PERIOD', TokenClass.UNARY_POSTFIX_OPERATOR, '.');
 
   static const TokenType PERIOD_PERIOD =
       const TokenType._('PERIOD_PERIOD', TokenClass.CASCADE_OPERATOR, '..');
 
   static const TokenType PLUS =
       const TokenType._('PLUS', TokenClass.ADDITIVE_OPERATOR, '+');
 
   static const TokenType PLUS_EQ =
       const TokenType._('PLUS_EQ', TokenClass.ASSIGNMENT_OPERATOR, '+=');
 
   static const TokenType PLUS_PLUS =
-      const TokenType._('PLUS_PLUS', TokenClass.UNARY_PREFIX_OPERATOR, '++');
+      const TokenType._('PLUS_PLUS', TokenClass.UNARY_POSTFIX_OPERATOR, '++');
 
   static const TokenType QUESTION =
       const TokenType._('QUESTION', TokenClass.CONDITIONAL_OPERATOR, '?');
 
   static const TokenType QUESTION_PERIOD = const TokenType._(
       'QUESTION_PERIOD', TokenClass.UNARY_POSTFIX_OPERATOR, '?.');
 
   static const TokenType QUESTION_QUESTION =
       const TokenType._('QUESTION_QUESTION', TokenClass.IF_NULL_OPERATOR, '??');
 
@@ skipping 222 matching lines @@
  */
 class _EndOfFileTokenType extends TokenType {
   /**
    * Initialize a newly created token.
    */
   const _EndOfFileTokenType() : super._('EOF', TokenClass.NO_CLASS, '');
 
   @override
   String toString() => '-eof-';
 }