chrome/common/extensions/api/networking_private.json - Issue 275543005: Use GUID instead of ServicePath in networkingPrivate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/networking_private.json

Issue 275543005: Use GUID instead of ServicePath in networkingPrivate API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('k') | chrome/test/data/extensions/api_test/networking/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/networking_private.json

diff --git a/chrome/common/extensions/api/networking_private.json b/chrome/common/extensions/api/networking_private.json

index b9f66e8b7381bc812c98c05548c972d2eb30f519..db603ccf76241100603be8fa2a5cd8c4010b39b6 100644

--- a/chrome/common/extensions/api/networking_private.json

+++ b/chrome/common/extensions/api/networking_private.json

@@ -173,7 +173,7 @@

"type": "function",

"parameters": [

{

- "name": "guid",

+ "name": "networkGuid",

"type": "string"

}

]

@@ -315,7 +315,7 @@

"description": "Properties of the destination to use in verifying that it is a trusted device."

{

- "name": "guid",

+ "name": "networkGuid",

"type": "string",

"description": "A string containing the unique identifier of the network to get credentials for."

@@ -410,12 +410,12 @@

{

"name": "getCaptivePortalStatus",

- "description": "Returns captive portal status for the network with networkGuid.",

+ "description": "Returns captive portal status for the network matching 'guid'.",

"parameters": [

{

- "name": "networkPath",

+ "name": "networkGuid",

"type": "string",

- "description": "The path of the network to get captive portal status."

+ "description": "The guid of the network to get captive portal status."

{

"name": "callback",

@@ -459,10 +459,10 @@

{

"name": "onPortalDetectionCompleted",

"type": "function",

- "description": "Fired when a portal detection for a network completes. Sends a name of the network and corresponding captive portal status.",

+ "description": "Fired when a portal detection for a network completes. Sends the guid of the network and the corresponding captive portal status.",

"parameters": [

{

- "name": "networkPath",

+ "name": "networkGuid",

"type": "string"

{