Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8673)

Unified Diff: chromeos/network/network_state_handler.h

Issue 275543005: Use GUID instead of ServicePath in networkingPrivate API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 314a975ba1a9e8655116f3858fcfde08f06af116..f926718833a6d4cf60da9f311df908f057a5fc25 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -175,6 +175,11 @@ class CHROMEOS_EXPORT NetworkStateHandler
// Finds and returns a favorite state by |service_path| or NULL if not found.
const FavoriteState* GetFavoriteState(const std::string& service_path) const;
+ // Finds the FavoriteState associated with |guid|. Note: The FavoriteState
+ // may or may not be in a profile (IsProfile() may be false), and may or may
+ // not be visible.
+ const FavoriteState* GetFavoriteStateFromGuid(const std::string& guid) const;
+
// Requests a network scan. This may trigger updates to the network
// list, which will trigger the appropriate observer calls.
void RequestScan() const;
@@ -288,6 +293,7 @@ class CHROMEOS_EXPORT NetworkStateHandler
private:
typedef std::list<base::Closure> ScanCallbackList;
typedef std::map<std::string, ScanCallbackList> ScanCompleteCallbackMap;
+ typedef std::map<std::string, std::string> SpecifierGuidMap;
friend class NetworkStateHandlerTest;
FRIEND_TEST_ALL_PREFIXES(NetworkStateHandlerTest, NetworkStateHandlerStub);
@@ -296,6 +302,10 @@ class CHROMEOS_EXPORT NetworkStateHandler
void UpdateNetworkStateProperties(NetworkState* network,
const base::DictionaryValue& properties);
+ // Ensure a valid GUID for FavoriteState and update the NetworkState GUID from
+ // the corresponding FavoriteState if necessary.
+ void UpdateGuid(ManagedState* managed);
+
// Sends DeviceListChanged() to observers and logs an event.
void NotifyDeviceListChanged();
@@ -305,6 +315,8 @@ class CHROMEOS_EXPORT NetworkStateHandler
DeviceState* GetModifiableDeviceState(const std::string& device_path) const;
NetworkState* GetModifiableNetworkState(
const std::string& service_path) const;
+ FavoriteState* GetModifiableFavoriteState(
+ const std::string& service_path) const;
ManagedState* GetModifiableManagedState(const ManagedStateList* managed_list,
const std::string& path) const;
@@ -357,6 +369,9 @@ class CHROMEOS_EXPORT NetworkStateHandler
// Callbacks to run when a scan for the technology type completes.
ScanCompleteCallbackMap scan_complete_callbacks_;
+ // Map of network specifiers to guids.
+ SpecifierGuidMap specifier_guid_map_;
+
DISALLOW_COPY_AND_ASSIGN(NetworkStateHandler);
};

Powered by Google App Engine
This is Rietveld 408576698