Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4578)

Unified Diff: chrome/test/data/extensions/api_test/networking/test.js

Issue 275543005: Use GUID instead of ServicePath in networkingPrivate API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/networking/test.js
diff --git a/chrome/test/data/extensions/api_test/networking/test.js b/chrome/test/data/extensions/api_test/networking/test.js
index aaf8626e828f6593ca18192f833ec6babf9d1758..8576c9e37e71f81b5596233072431e2760413285 100644
--- a/chrome/test/data/extensions/api_test/networking/test.js
+++ b/chrome/test/data/extensions/api_test/networking/test.js
@@ -56,12 +56,12 @@ var privateHelpers = {
done();
};
},
- watchForCaptivePortalState: function(expectedNetworkPath,
+ watchForCaptivePortalState: function(expectedGuid,
expectedState,
done) {
var self = this;
- this.onPortalDetectionCompleted = function(networkPath, state) {
- assertEq(expectedNetworkPath, networkPath);
+ this.onPortalDetectionCompleted = function(guid, state) {
+ assertEq(expectedGuid, guid);
assertEq(expectedState, state);
chrome.networkingPrivate.onPortalDetectionCompleted.removeListener(
self.onPortalDetectionCompleted);
@@ -86,17 +86,17 @@ var availableTests = [
function startConnectNonexistent() {
chrome.networkingPrivate.startConnect(
"nonexistent_path",
- callbackFail("configure-failed"));
+ callbackFail("Error.InvalidNetworkGuid"));
},
function startDisconnectNonexistent() {
chrome.networkingPrivate.startDisconnect(
"nonexistent_path",
- callbackFail("not-found"));
+ callbackFail("Error.InvalidNetworkGuid"));
},
function startGetPropertiesNonexistent() {
chrome.networkingPrivate.getProperties(
"nonexistent_path",
- callbackFail("Error.DBusFailed"));
+ callbackFail("Error.InvalidNetworkGuid"));
},
function createNetwork() {
chrome.networkingPrivate.createNetwork(
@@ -142,7 +142,7 @@ var availableTests = [
"Type": "WiFi",
"WiFi": {
"Security": "WEP-PSK",
- "SignalStrength": 0
+ "SignalStrength": 1
}
},
{
@@ -163,12 +163,12 @@ var availableTests = [
}
},
{
- "Connectable": false,
"Cellular": {
"ActivationState": "not-activated",
"NetworkTechnology": "GSM",
"RoamingState": "home"
},
+ "Connectable": false,
"ConnectionState": "NotConnected",
"GUID": "stub_cellular1",
"Name": "cellular1",
@@ -188,7 +188,7 @@ var availableTests = [
"Type": "WiFi",
"WiFi": {
"Security": "WEP-PSK",
- "SignalStrength": 0
+ "SignalStrength": 1
}
},
{
@@ -255,7 +255,11 @@ var availableTests = [
"Active": "NotConnected",
"Effective": "Unmanaged"
},
- "GUID": "stub_wifi2",
+ "GUID": {
+ "Active": "stub_wifi2",
+ "Effective": "UserPolicy",
+ "UserPolicy": "stub_wifi2"
+ },
"Name": {
"Active": "wifi2_PSK",
"Effective": "UserPolicy",
@@ -339,7 +343,7 @@ var availableTests = [
function getStateNonExistent() {
chrome.networkingPrivate.getState(
'non_existent',
- callbackFail('Error.InvalidParameter'));
+ callbackFail('Error.InvalidNetworkGuid'));
},
function onNetworksChangedEventConnect() {
var network = "stub_wifi2";
@@ -380,9 +384,10 @@ var availableTests = [
}));
},
function verifyAndEncryptCredentials() {
+ var network_guid = "stub_wifi2";
chrome.networkingPrivate.verifyAndEncryptCredentials(
verificationProperties,
- "guid",
+ network_guid,
callbackPass(function(result) {
assertEq("encrypted_credentials", result);
}));

Powered by Google App Engine
This is Rietveld 408576698