chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc - Issue 275543005: Use GUID instead of ServicePath in networkingPrivate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

Issue 275543005: Use GUID instead of ServicePath in networkingPrivate API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_apitest.cc » ('j') | chromeos/dbus/fake_shill_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

index 64d5dbf8d9a8c9df34a7d9f82b49c393dbf08be2..9b4ad43543ca09d5004592423341b8df9c805785 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

@@ -87,10 +87,7 @@ bool NetworkingPrivateGetManagedPropertiesFunction::RunAsync() {

void NetworkingPrivateGetManagedPropertiesFunction::Success(

const std::string& network_guid,

const base::DictionaryValue& dictionary) {

- scoped_ptr<base::DictionaryValue> network_properties(dictionary.DeepCopy());

- network_properties->SetStringWithoutPathExpansion(onc::network_config::kGUID,

- network_guid);

- SetResult(network_properties.release());

+ SetResult(dictionary.DeepCopy());

SendResponse(true);

}