Use GUID instead of ServicePath in networkingPrivate API

chromeos/network/onc/onc_translator_shill_to_onc.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_translator.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "chromeos/network/network_state.h"
+#include "chromeos/network/network_state_handler.h"
 #include "chromeos/network/onc/onc_signature.h"
 #include "chromeos/network/onc/onc_translation_tables.h"
 #include "chromeos/network/shill_property_util.h"
 #include "components/onc/onc_constants.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 namespace onc {
 
 namespace {
@@ skipping 426 matching lines @@
 
 scoped_ptr<base::DictionaryValue> TranslateShillServiceToONCPart(
     const base::DictionaryValue& shill_dictionary,
     const OncValueSignature* onc_signature) {
   CHECK(onc_signature != NULL);
 
   ShillToONCTranslator translator(shill_dictionary, *onc_signature);
   return translator.CreateTranslatedONCObject();
 }
 
+scoped_ptr<base::ListValue> TranslateShillNetworkListToONC(

[pneubeck (no reviews), 2014/05/08 13:25:12]

see my comment in the other CL. Please move out of network/onc/ into e.g.
network/network_util

[stevenjb, 2014/05/08 22:32:26]

Done, but note: there is a dependency on NetworkState::StateIsConnected()

[pneubeck (no reviews), 2014/05/12 13:37:07]

Yes, that one is only comparing to Shill constants and could be part of
shill_property_utils.
At least it's only a static function.

+    NetworkTypePattern pattern) {
+  NetworkStateHandler::NetworkStateList network_states;
+  NetworkHandler::Get()->network_state_handler()->GetNetworkListByType(
+      pattern, &network_states);
+
+  scoped_ptr<base::ListValue> network_properties_list(new base::ListValue);
+  for (NetworkStateHandler::NetworkStateList::iterator it =
+           network_states.begin();
+       it != network_states.end();
+       ++it) {
+    base::DictionaryValue shill_dictionary;
+    (*it)->GetStateProperties(&shill_dictionary);
+
+    scoped_ptr<base::DictionaryValue> onc_network_part =
+        TranslateShillServiceToONCPart(
+            shill_dictionary, &chromeos::onc::kNetworkWithStateSignature);
+    network_properties_list->Append(onc_network_part.release());
+  }
+  return network_properties_list.Pass();
+}
+
 }  // namespace onc
 }  // namespace chromeos