Refactoring the debug creation of BeginFrameArgs objects to be in unittest code only.

cc/test/output_test_common.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_TEST_OUTPUT_TEST_COMMON_H_

[danakj, 2014/05/08 21:37:48]

I'd prefer begin_frame_args_common.h for this, it's coincidental that we ended
up breaking cc into directories in similar way that test filers were broken up.
Smaller more focused files would be good, we don't need to group everything that
tests things in output/ together.

[mithro-old, 2014/05/08 21:41:16]

Is there any reason not to use cc/debug/begin_frames_args.h or is
cc/debug/begin_frames_args_common.h better?

[danakj, 2014/05/08 21:46:07]

I assume you mean cc/test/ not cc/debug/ ?

I'd use begin_frame_args.h if this file defined a class called BeginFrameArgs.
Since it doesn't we should clarify that. _common is a "common" way to do that :)

+#define CC_TEST_OUTPUT_TEST_COMMON_H_
+
+#include <iosfwd>
+
+#include "base/time/time.h"
+#include "cc/output/begin_frame_args.h"
+
+namespace cc {
+
+// Functions for quickly creating BeginFrameArgs
+BeginFrameArgs BeginFrameArgsCreateForTesting();
+BeginFrameArgs BeginFrameArgsCreateExpiredForTesting();
+BeginFrameArgs BeginFrameArgsCreateQuick(int64 frame_time,
+                                         int64 deadline,
+                                         int64 interval);
+
+}  // namespace cc
+
+#endif  // CC_TEST_OUTPUT_TEST_COMMON_H_