Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 27554003: Publish the location of results.html to user in keyboard interrupt scenario.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 27554003: Publish the location of results.html to user in keyboard interrupt scenario. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Making the result as file url. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('j') | Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 4cd1f5b4fd78b2c5c3db9c1dd926f2f78fe71f41..35029d319cf1ea40b3563faa7e36feb78ef81e71 100644

--- a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -247,6 +247,7 @@ class Manager(object):

summarized_failing_results = test_run_results.summarize_results(self._port, self._expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, only_include_failing=True)

exit_code = summarized_failing_results['num_regressions']

+ results_path = ""

if not self._options.dry_run:

self._write_json_files(summarized_full_results, summarized_failing_results, initial_results)

self._upload_json_files()

@@ -259,7 +260,7 @@ class Manager(object):

if self._options.show_results and (exit_code or (self._options.full_results_html and initial_results.total_failures)):

self._port.show_results_html_file(results_path)

self._printer.print_results(time.time() - start_time, initial_results, summarized_failing_results)

- return test_run_results.RunDetails(exit_code, summarized_full_results, summarized_failing_results, initial_results, retry_results, enabled_pixel_tests_in_retry)

+ return test_run_results.RunDetails(exit_code, summarized_full_results, summarized_failing_results, initial_results, retry_results, enabled_pixel_tests_in_retry, results_path)

def _run_tests(self, tests_to_run, tests_to_skip, repeat_each, iterations, num_workers, retrying):