Publish the location of results.html to user in keyboard interrupt scenario.

Publish the location of results.html to user in keyboard interrupt scenario.

In case of Ctrl+C (keyboard interrupt), results.html is generated but user
is never notified neither of its generation nor stored location of it. It
is not required in regular usecase because we open the browser window with
results.html loaded, but in other usecase it should be notified to atleast
let the user know the result is stored for him in case he wishes to see it.

R=dpranke

BUG=None

TEST=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160234

[r.kasibhatla, 2013-10-17 11:50:37]

PTAL.

[r.kasibhatla, 2013-10-19 00:37:32]

On 2013/10/18 03:34:05, r.kasibhatla wrote:

Ping. :)

[r.kasibhatla, 2013-10-20 18:02:59]

Ping...

[Dirk Pranke, 2013-10-21 18:38:47]

I'm a bit lukewarm on this change. For me, when I hit ctrl-C I want there to be
as little text afterwards as possible (to get me back to the command prompt).

In addition, the results.html is always written to a predictable location
(src/webkit/Release/layout-test-results/results.html), so I know where to go to
find it.

However, I can clearly see the advantage to having the URL be printed out for
simple copy & paste.

As an alternative, we already print the location of the results directory at the
beginning of the run. How about if we change that line to print the URL of the
results file instead (see printing.py:80), or print both?

https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
File Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (right):

https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:110: self.results
= results_path
This should probably be self.results_path . 'results' by itself is ambiguous as
part of this data structure.

https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
File Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right):

https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:370:
printer.writeln('run-webkit-tests iteration result stored at file://' +
run_details.results)
I would probably change the output to something like "View the results at
file:///" ... .

[r.kasibhatla, 2013-10-21 19:39:51]

On 2013/10/21 18:38:47, Dirk Pranke wrote:
> I'm a bit lukewarm on this change. For me, when I hit ctrl-C I want there to
be
> as little text afterwards as possible (to get me back to the command prompt).
> 
> In addition, the results.html is always written to a predictable location
> (src/webkit/Release/layout-test-results/results.html), so I know where to go
to
> find it.
> 
> However, I can clearly see the advantage to having the URL be printed out for
> simple copy & paste.
> 
> As an alternative, we already print the location of the results directory at
the
> beginning of the run. How about if we change that line to print the URL of the
> results file instead (see printing.py:80), or print both?
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> File Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (right):
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:110:
self.results
> = results_path
> This should probably be self.results_path . 'results' by itself is ambiguous
as
> part of this data structure.
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> File Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right):
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:370:
> printer.writeln('run-webkit-tests iteration result stored at file://' +
> run_details.results)
> I would probably change the output to something like "View the results at
> file:///" ... .

It sounds great. I will make the changes to print the result location at start.

[r.kasibhatla, 2013-10-22 04:09:12]

On 2013/10/21 18:38:47, Dirk Pranke wrote:
> I'm a bit lukewarm on this change. For me, when I hit ctrl-C I want there to
be
> as little text afterwards as possible (to get me back to the command prompt).
> 
> In addition, the results.html is always written to a predictable location
> (src/webkit/Release/layout-test-results/results.html), so I know where to go
to
> find it.
In my experience, I have seen people trying to find the location of the results,
hence making this change to enable the newcomers or people who always run all
layout tests (and doesn't bother to see where the results are stored :p) to
instantly realize where the final results would be present. However, I do
realize we need not print both before and after the the exectution the results
location.
> 
> However, I can clearly see the advantage to having the URL be printed out for
> simple copy & paste.
I have modified existing printing of results dir itself to instead point to file
URL which can be copy-pasted or even directly open the link in browser (through
context menu).
> 
> As an alternative, we already print the location of the results directory at
the
> beginning of the run. How about if we change that line to print the URL of the
> results file instead (see printing.py:80), or print both?
Done.
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> File Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (right):
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:110:
self.results
> = results_path
> This should probably be self.results_path . 'results' by itself is ambiguous
as
> part of this data structure.
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> File Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right):
> 
>
https://codereview.chromium.org/27554003/diff/4001/Tools/Scripts/webkitpy/lay...
> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:370:
> printer.writeln('run-webkit-tests iteration result stored at file://' +
> run_details.results)
> I would probably change the output to something like "View the results at
> file:///" ... .
All these changes are now no longer needed - simple single line change... :).
Yay...

[Dirk Pranke, 2013-10-22 16:27:48]

lgtm

[Dirk Pranke, 2013-10-22 16:27:58]

thanks!

[commit-bot: I haz the power, 2013-10-22 17:20:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/27554003/76001

[commit-bot: I haz the power, 2013-10-22 18:16:21]

Change committed as 160234