Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/compiler/lib/src/ssa/types_propagation.dart

Issue 2755353003: dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/types_propagation.dart
diff --git a/pkg/compiler/lib/src/ssa/types_propagation.dart b/pkg/compiler/lib/src/ssa/types_propagation.dart
index 5b1473a762adc9f103ad32226529370853bdb82b..891d9d6bb6fae9652fdfdcc08f1e27feab5c97cc 100644
--- a/pkg/compiler/lib/src/ssa/types_propagation.dart
+++ b/pkg/compiler/lib/src/ssa/types_propagation.dart
@@ -396,7 +396,9 @@ class SsaTypePropagator extends HBaseVisitor implements OptimizationPhase {
addDependentInstructionsToWorkList(next);
}
} else {
- bool hasCandidates() => receiver.dominatedUsers(instruction).length > 1;
+ bool hasCandidates() => DominatedUses
+ .of(receiver, instruction, excludeDominator: true)
+ .isNotEmpty;
if ((receiver.usedBy.length <= _MAX_QUICK_USERS)
? (hasCandidates() && computeNewType() != receiverType)
« pkg/compiler/lib/src/ssa/optimize.dart ('K') | « pkg/compiler/lib/src/ssa/optimize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698