Issue 275533002: Handle h_addr in a more libc independent way.

Issue 275533002: Handle h_addr in a more libc independent way. (Closed)

Created:
6 years, 7 months ago by bradn

Modified:
6 years, 7 months ago

Reviewers:
binji, Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle h_addr in a more libc independent way. Which glibc defines h_addr as a macro to h_addr_list[0], newlib has a separate h_addr member in struct hostent. To correctly handle this, h_addr should be set to match h_addr_list[0]. BUG=None R=binji@chromium.org TEST=bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270026

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : fix #

Patch Set 4 : merge #

Patch Set 5 : fix #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	native_client_sdk/src/libraries/nacl_io/host_resolver.cc	View	1 2 3 4	2 chunks	+11 lines, -0 lines	0 comments	Download
	M	native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/275533002/diff/1/native_client_sdk/src/libraries/nacl_io/host_resolver.cc File native_client_sdk/src/libraries/nacl_io/host_resolver.cc (right): https://codereview.chromium.org/275533002/diff/1/native_client_sdk/src/libraries/nacl_io/host_resolver.cc#newcode423 native_client_sdk/src/libraries/nacl_io/host_resolver.cc:423: hostent_.h_addr_list = NULL; hostent_.h_addr = NULL https://codereview.chromium.org/275533002/diff/1/native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc File ...

6 years, 7 months ago (2014-05-07 22:35:04 UTC) #2

bradn

https://codereview.chromium.org/275533002/diff/1/native_client_sdk/src/libraries/nacl_io/host_resolver.cc File native_client_sdk/src/libraries/nacl_io/host_resolver.cc (right): https://codereview.chromium.org/275533002/diff/1/native_client_sdk/src/libraries/nacl_io/host_resolver.cc#newcode423 native_client_sdk/src/libraries/nacl_io/host_resolver.cc:423: hostent_.h_addr_list = NULL; On 2014/05/07 22:35:04, binji wrote: > ...

6 years, 7 months ago (2014-05-07 22:39:06 UTC) #3

Sam Clegg

lgtm https://codereview.chromium.org/275533002/diff/20001/native_client_sdk/src/libraries/nacl_io/host_resolver.cc File native_client_sdk/src/libraries/nacl_io/host_resolver.cc (right): https://codereview.chromium.org/275533002/diff/20001/native_client_sdk/src/libraries/nacl_io/host_resolver.cc#newcode202 native_client_sdk/src/libraries/nacl_io/host_resolver.cc:202: hostent_.haddr = hostent_.h_addr_list[0]; With the compiler not warn ...

6 years, 7 months ago (2014-05-07 23:20:15 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/275533002/80001

6 years, 7 months ago (2014-05-13 00:12:43 UTC) #6

Message was sent while issue was closed.

Change committed as 270026

Expand Messages | Collapse Messages