fix `?` incorrectly being used in an implicit instantiation

fix `?` incorrectly being used in an implicit instantiation

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/3aa1be67d953d7ed50ce4965b42829326cb89dbd

[Jennifer Messerly, 2017-03-18 01:27:56]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2017-03-18 01:45:30]

lgtm

https://codereview.chromium.org/2755283002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/strong_mode_test.dart (right):

https://codereview.chromium.org/2755283002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/strong_mode_test.dart:1113:
test_inferGenericInstantiation() async {
Can you add a short comment at the header of these to say what they're testing? 
I've started doing that, it helps me a lot when I need to go back and read them.

https://codereview.chromium.org/2755283002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/strong_mode_test.dart:1147: assertErrors(source,
[StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
Shouldn't there be an error because the inferred bounds don't match as well?

[Jennifer Messerly, 2017-03-18 02:00:07]

thanks Leaf!

https://codereview.chromium.org/2755283002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/strong_mode_test.dart (right):

https://codereview.chromium.org/2755283002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/strong_mode_test.dart:1113:
test_inferGenericInstantiation() async {
On 2017/03/18 01:45:30, Leaf wrote:
> Can you add a short comment at the header of these to say what they're
testing? 
> I've started doing that, it helps me a lot when I need to go back and read
them.

Done.

https://codereview.chromium.org/2755283002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/strong_mode_test.dart:1147: assertErrors(source,
[StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
On 2017/03/18 01:45:30, Leaf wrote:
> Shouldn't there be an error because the inferred bounds don't match as well?

it looks like we don't actually check bounds anywhere for instantiated generic
functions except in inference.

I'll go ahead and restore the inference errors for them.

[Jennifer Messerly, 2017-03-18 02:00:32]

Description was changed from

==========
fix `?` incorrectly being used in an implicit instantiation
==========

to

==========
fix `?` incorrectly being used in an implicit instantiation

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3aa1be67d953d7ed50ce4965b42829326cb89dbd
==========

[Jennifer Messerly, 2017-03-18 02:00:33]

Committed patchset #4 (id:60001) manually as
3aa1be67d953d7ed50ce4965b42829326cb89dbd (presubmit successful).