[NaCl SDK] Make build_projects quiet by default.

[NaCl SDK] Make build_projects quiet by default.

BUG=none
R=sbc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269952

[Sam Clegg, 2014-05-07 23:25:23]

I'm a fan of this change. I tried to do this a while ago myself but never got it
to a place I was happy with.

https://codereview.chromium.org/275523003/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/buildbot_common.py (right):

https://codereview.chromium.org/275523003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:105: def Run(args,
cwd=None, env=None, shell=False, verbose=True):
What about having a buildbot_common.verbose variable that we can set just once
at startup rather than having to pass the state around?

https://codereview.chromium.org/275523003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:205: print >> sys.stderr,
'@@@STEP_LINK@download@%s@@@' % url
I don't like the >> syntax.

How about sys.stderr.write()?

[binji, 2014-05-07 23:51:15]

https://codereview.chromium.org/275523003/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/buildbot_common.py (right):

https://codereview.chromium.org/275523003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:105: def Run(args,
cwd=None, env=None, shell=False, verbose=True):
On 2014/05/07 23:25:23, Sam Clegg wrote:
> What about having a buildbot_common.verbose variable that we can set just once
> at startup rather than having to pass the state around?

Done.

https://codereview.chromium.org/275523003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:205: print >> sys.stderr,
'@@@STEP_LINK@download@%s@@@' % url
On 2014/05/07 23:25:23, Sam Clegg wrote:
> I don't like the >> syntax.
> 
> How about sys.stderr.write()?

Done.

[Sam Clegg, 2014-05-07 23:56:46]

nice.

More python3 compatible as well :)

lgtm.

[Sam Clegg, 2014-05-07 23:56:46]

nice.

More python3 compatible as well :)

lgtm.

[binji, 2014-05-09 16:30:34]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2014-05-09 16:35:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/binji@chromium.org/275523003/40001

[commit-bot: I haz the power, 2014-05-09 21:26:09]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 23:26:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 23:26:35]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[binji, 2014-05-12 16:59:47]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2014-05-12 17:00:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/binji@chromium.org/275523003/40001

[commit-bot: I haz the power, 2014-05-13 01:24:07]

Change committed as 269952