Issue 27552003: Have WorkerScriptController::workerGlobalScope return a reference

Issue 27552003: Have WorkerScriptController::workerGlobalScope return a reference (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, Nils Barth (inactive), kojih, loislo+blink_chromium.org, jsbell+bindings_chromium.org, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have WorkerScriptController::workerGlobalScope return a reference Have WorkerScriptController::workerGlobalScope return a reference as it can never return null. It makes the calling code look safer. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159970

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -21 lines)			Patch
M	Source/bindings/v8/V8Utilities.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/WorkerScriptController.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/WorkerScriptController.cpp	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/workers/WorkerGlobalScope.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/DatabaseObserver.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/wtf/PassRefPtr.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Inactive

On 2013/10/17 17:38:42, adamk wrote: > lgtm tkent@, could you please take a look as ...

7 years, 2 months ago (2013-10-17 17:52:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27552003/1

7 years, 2 months ago (2013-10-18 00:17:38 UTC) #5

commit-bot: I haz the power

Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=9260

7 years, 2 months ago (2013-10-18 00:40:32 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27552003/1

7 years, 2 months ago (2013-10-18 03:12:08 UTC) #7

Message was sent while issue was closed.

Change committed as 159970

Expand Messages | Collapse Messages