Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2755133003: Tighten up kernel pubspec after 685045d61976b72bbe94a58c1a19cdea8d638840 (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
Reviewers:
asgerf, ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tighten up kernel pubspec after 685045d61976b72bbe94a58c1a19cdea8d638840 Commit 685045d61976b72bbe94a58c1a19cdea8d638840 removed the dependencies on analyzer from pkg/kernel/lib. Some dependencies on analyzer remain in pkg/kernel/bin and pkg/kernel/test, but these are dev dependencies only. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/0a76a148d1fcc5c40c505b98d837ec1dd38d8027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/kernel/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 9 months ago (2017-03-17 20:11:32 UTC) #2
ahe
lgtm
3 years, 9 months ago (2017-03-20 16:49:20 UTC) #3
Paul Berry
3 years, 9 months ago (2017-03-20 16:50:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a76a148d1fcc5c40c505b98d837ec1dd38d8027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698