Issue 275513003: Oilpan: Make DateTimeEditElement::m_editControlOwner and DateTimeFieldElement::m_fieldOwner strong …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275513003: Oilpan: Make DateTimeEditElement::m_editControlOwner and DateTimeFieldElement::m_fieldOwner strong … (Closed)

Created:
6 years, 7 months ago by tkent

Modified:
6 years, 7 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Make DateTimeEditElement::m_editControlOwner and DateTimeFieldElement::m_fieldOwner strong references. We don't need to use WeakMember for them because owners never die before owned elements. In non-Oilpan, owners can die before owned elements because parentNode is not a strong reference. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173590

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/html/shadow/DateTimeEditElement.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/shadow/DateTimeFieldElement.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

Please review this. A follow-up of https://codereview.chromium.org/267413002/

6 years, 7 months ago (2014-05-08 01:19:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/275513003/1

6 years, 7 months ago (2014-05-08 01:53:15 UTC) #4

Message was sent while issue was closed.

LGTM, thanks!

Expand Messages | Collapse Messages