Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 27551003: The content api for shouldoverrideurlloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: conditionalized the handlenavigation API for android Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index a3a6e5bc19079042abb9e9153e0f1076df4fe74d..b0346dc8a3b6bac22b121a4e7be27800da0e90ea 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -50,6 +50,7 @@ struct WebURLError;
namespace content {
+class DocumentState;
class RenderView;
class SynchronousCompositor;
struct KeySystemInfo;
@@ -168,13 +169,22 @@ class CONTENT_EXPORT ContentRendererClient {
// Returns true if a popup window should be allowed.
virtual bool AllowPopup();
+#ifdef OS_ANDROID
+ // TODO(sgurun) This callback is deprecated and will be removed as soon
+ // as android webview completes implementation of a resource throttle based
+ // shouldoverrideurl implementation. See crbug.com/325351
+ //
// Returns true if the navigation was handled by the embedder and should be
- // ignored by WebKit. This method is used by CEF.
- virtual bool HandleNavigation(blink::WebFrame* frame,
+ // ignored by WebKit. This method is used by CEF and android_webview.
+ virtual bool HandleNavigation(RenderView* view,
+ DocumentState* document_state,
+ int opener_id,
+ blink::WebFrame* frame,
const blink::WebURLRequest& request,
blink::WebNavigationType type,
blink::WebNavigationPolicy default_policy,
bool is_redirect);
+#endif
// Returns true if we should fork a new process for the given navigation.
// If |send_referrer| is set to false (which is the default), no referrer
« no previous file with comments | « no previous file | content/public/renderer/content_renderer_client.cc » ('j') | content/renderer/render_view_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698