The content api for shouldoverrideurlloading

content/public/renderer/content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 31 matching lines @@
 class WebSpeechSynthesizer;
 class WebSpeechSynthesizerClient;
 class WebThemeEngine;
 class WebURLRequest;
 struct WebPluginParams;
 struct WebURLError;
 }
 
 namespace content {
 
+class DocumentState;
 class RenderView;
 class SynchronousCompositor;
 struct KeySystemInfo;
 struct WebPluginInfo;
 
 // Embedder API for participating in renderer logic.
 class CONTENT_EXPORT ContentRendererClient {
  public:
   virtual ~ContentRendererClient() {}
 
@@ skipping 99 matching lines @@
       WebKit::WebSpeechSynthesizerClient* client);
 
   // Returns true if the renderer process should schedule the idle handler when
   // all widgets are hidden.
   virtual bool RunIdleHandlerWhenWidgetsHidden();
 
   // Returns true if a popup window should be allowed.
   virtual bool AllowPopup();
 
   // Returns true if the navigation was handled by the embedder and should be
-  // ignored by WebKit. This method is used by CEF.
-  virtual bool HandleNavigation(WebKit::WebFrame* frame,
+  // ignored by WebKit. This method is used by CEF and android_webview.
+  virtual bool HandleNavigation(RenderView* view,

[darin (slow to review), 2013/10/24 03:59:34]

Our intent is to delete this method. It is better to use the browser-side
ResourceThrottle hook. Note also, that the OOPIF infrastructure is moving way
more of the navigation system to the browser process. You are much better off
sitting on top of the ResourceThrottle infrastructure. What does that not
provide that you need?

[joth, 2013/11/22 07:03:20]

As a compromise to get this moving forward, how about we land this change but
wrap the whole function in ifdef OS_ANDROID.
- we'll open a bug to move to the ResourceThrottle if at all possible.
- Moving to throttle will be much more practical to do once we have unforked and
got automated tests covering this very bug-sensitive piece (not to mention we
can switch our canary builds back to master branch then, to do get manual QA and
dogfood coverage)
- If the resource throttle does prove unworkable, then I'm almost certain the
OOPIF changes to move nav to browser will completely remove our need for this
hook anyway (we'd much much rather get navigation layer hooks right there in the
browser than have to do our own render->browser hops and jumps)

+                                DocumentState* document_state,
+                                int opener_id,
+                                WebKit::WebFrame* frame,
                                 const WebKit::WebURLRequest& request,
                                 WebKit::WebNavigationType type,
                                 WebKit::WebNavigationPolicy default_policy,
                                 bool is_redirect);
 
   // Returns true if we should fork a new process for the given navigation.
   // If |send_referrer| is set to false (which is the default), no referrer
   // header will be send for the navigation. Otherwise, the referrer header is
   // set according to the frame's referrer policy.
   virtual bool ShouldFork(WebKit::WebFrame* frame,
@@ skipping 80 matching lines @@
 
   // Returns true if we should apply the cross-site document blocking policy to
   // this renderer process. Currently, we apply the policy only to a renderer
   // process running on a normal page from the web.
   virtual bool ShouldEnableSiteIsolationPolicy() const;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_