Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp. (Closed)
Patch Set: Mark before_first_contentful_paint. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
index cb00c68cb5b0c8afec1348cb04ef081df1fa5f3b..28a7ebeaf7ca0d6073d1c4ba2b1e89416dddc4d3 100644
--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h
@@ -6,15 +6,12 @@
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_PAGE_LOAD_METRICS_OBSERVER_H_
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/browser/predictors/resource_prefetch_predictor.h"
alexilin 2017/03/17 14:46:46 nit: NavigationID is declared in resource_prefetch
trevordixon 2017/03/27 12:30:08 Done.
namespace content {
class WebContents;
}
-namespace predictors {
-class ResourcePrefetchPredictor;
-}
-
namespace internal {
extern const char kHistogramResourcePrefetchPredictorFirstContentfulPaint[];
@@ -35,7 +32,8 @@ class ResourcePrefetchPredictorPageLoadMetricsObserver
// Public for testing. Normally one should use CreateIfNeeded. Predictor must
// outlive this observer.
explicit ResourcePrefetchPredictorPageLoadMetricsObserver(
- predictors::ResourcePrefetchPredictor* predictor);
+ predictors::ResourcePrefetchPredictor* predictor,
+ predictors::NavigationID navigation_id);
~ResourcePrefetchPredictorPageLoadMetricsObserver() override;
@@ -56,6 +54,8 @@ class ResourcePrefetchPredictorPageLoadMetricsObserver
private:
predictors::ResourcePrefetchPredictor* predictor_;
+ predictors::NavigationID navigation_id_;
+
DISALLOW_COPY_AND_ASSIGN(ResourcePrefetchPredictorPageLoadMetricsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698