Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h

Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp. (Closed)
Patch Set: Just check db. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_P AGE_LOAD_METRICS_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_P AGE_LOAD_METRICS_OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_P AGE_LOAD_METRICS_OBSERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTOR_P AGE_LOAD_METRICS_OBSERVER_H_
7 7
8 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 8 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
9 #include "chrome/browser/predictors/resource_prefetch_common.h"
alexilin 2017/04/28 11:22:03 nit: Do we need this include?
trevordixon 2017/04/28 12:39:54 Deleted.
9 10
10 namespace content { 11 namespace content {
11 class WebContents; 12 class WebContents;
12 } 13 }
13 14
14 namespace predictors { 15 namespace predictors {
15 class ResourcePrefetchPredictor; 16 class ResourcePrefetchPredictor;
16 } 17 }
17 18
18 namespace internal { 19 namespace internal {
19 20
20 extern const char kHistogramResourcePrefetchPredictorFirstContentfulPaint[]; 21 extern const char kHistogramResourcePrefetchPredictorFirstContentfulPaint[];
21 extern const char kHistogramResourcePrefetchPredictorFirstMeaningfulPaint[]; 22 extern const char kHistogramResourcePrefetchPredictorFirstMeaningfulPaint[];
22 23
23 } // namespace internal 24 } // namespace internal
24 25
25 // Observer responsible for recording page load metrics relevant to 26 // Observer responsible for recording page load metrics relevant to
26 // ResourcePrefetchPredictor. 27 // ResourcePrefetchPredictor.
27 class ResourcePrefetchPredictorPageLoadMetricsObserver 28 class ResourcePrefetchPredictorPageLoadMetricsObserver
28 : public page_load_metrics::PageLoadMetricsObserver { 29 : public page_load_metrics::PageLoadMetricsObserver {
29 public: 30 public:
30 // Returns a ResourcePrefetchPredictorPageLoadMetricsObserver, or nullptr if 31 // Returns a ResourcePrefetchPredictorPageLoadMetricsObserver, or nullptr if
31 // it is not needed. 32 // it is not needed.
32 static std::unique_ptr<ResourcePrefetchPredictorPageLoadMetricsObserver> 33 static std::unique_ptr<ResourcePrefetchPredictorPageLoadMetricsObserver>
33 CreateIfNeeded(content::WebContents* web_contents); 34 CreateIfNeeded(content::WebContents* web_contents);
34 35
35 // Public for testing. Normally one should use CreateIfNeeded. Predictor must 36 // Public for testing. Normally one should use CreateIfNeeded. Predictor must
36 // outlive this observer. 37 // outlive this observer.
37 explicit ResourcePrefetchPredictorPageLoadMetricsObserver( 38 explicit ResourcePrefetchPredictorPageLoadMetricsObserver(
38 predictors::ResourcePrefetchPredictor* predictor); 39 predictors::ResourcePrefetchPredictor* predictor,
40 content::WebContents* web_contents);
39 41
40 ~ResourcePrefetchPredictorPageLoadMetricsObserver() override; 42 ~ResourcePrefetchPredictorPageLoadMetricsObserver() override;
41 43
42 // page_load_metrics::PageLoadMetricsObserver: 44 // page_load_metrics::PageLoadMetricsObserver:
43 ObservePolicy OnStart(content::NavigationHandle* navigation_handle, 45 ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
44 const GURL& currently_commited_url, 46 const GURL& currently_commited_url,
45 bool started_in_foreground) override; 47 bool started_in_foreground) override;
46 ObservePolicy OnHidden( 48 ObservePolicy OnHidden(
47 const page_load_metrics::PageLoadTiming& timing, 49 const page_load_metrics::PageLoadTiming& timing,
48 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 50 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
49 void OnFirstContentfulPaint( 51 void OnFirstContentfulPaint(
50 const page_load_metrics::PageLoadTiming& timing, 52 const page_load_metrics::PageLoadTiming& timing,
51 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 53 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
52 void OnFirstMeaningfulPaint( 54 void OnFirstMeaningfulPaint(
53 const page_load_metrics::PageLoadTiming& timing, 55 const page_load_metrics::PageLoadTiming& timing,
54 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 56 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
55 57
56 private: 58 private:
57 predictors::ResourcePrefetchPredictor* predictor_; 59 predictors::ResourcePrefetchPredictor* predictor_;
60 content::WebContents* web_contents_;
61 bool record_histograms_;
58 62
59 DISALLOW_COPY_AND_ASSIGN(ResourcePrefetchPredictorPageLoadMetricsObserver); 63 DISALLOW_COPY_AND_ASSIGN(ResourcePrefetchPredictorPageLoadMetricsObserver);
60 }; 64 };
61 65
62 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTO R_PAGE_LOAD_METRICS_OBSERVER_H_ 66 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RESOURCE_PREFETCH_PREDICTO R_PAGE_LOAD_METRICS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698